Re: Git revision in tarballs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Git revision in tarballs
Date
Msg-id 3618220.1626359741@sss.pgh.pa.us
Whole thread Raw
In response to Re: Git revision in tarballs  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Git revision in tarballs  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Putting it in the tarball making script certainly works for me,
> though, if that's what people prefer. And that does away with the
> "clean" part as that one blows away the whole directory between each
> run.

Actually, we *have* to do it over there, because what that script
does is

   # Export the selected git ref
   git archive ${i} | tar xf - -C pgsql

   cd pgsql
   ./configure
   # some irrelevant stuff
   make dist

So there's no .git subdirectory in the directory it runs "make dist"
in.  Now maybe it'd work anyway because of the GIT_DIR environment
variable, but what I think is more likely is that the file would
end up containing the current master-branch HEAD commit, whereas
the thing we actually want to record here is ${i}.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: SQL:2011 PERIODS vs Postgres Ranges?
Next
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Use optimized single-datum tuplesort in ExecSort