Re: [PATCHES] patch for minor Win32 makefile bug - Mailing list pgsql-ports

From Tom Lane
Subject Re: [PATCHES] patch for minor Win32 makefile bug
Date
Msg-id 3610.986181834@sss.pgh.pa.us
Whole thread Raw
In response to patch for minor Win32 makefile bug  (Fred Yankowski <fcy@acm.org>)
Responses Re: [PATCHES] patch for minor Win32 makefile bug  (Fred Yankowski <fred@ontosys.com>)
Re: Re: [PATCHES] patch for minor Win32 makefile bug  (Jason Tishler <Jason.Tishler@dothill.com>)
List pgsql-ports
Fred Yankowski <fcy@acm.org> writes:
> While working on a patch that allows postmaster to run as an NT service
> with Cygwin, I found minor problem in backend/Makefile.  In order to add
> an additional library to the final link/build of postgres.exe, I changed
> the DLLLIBS variable in makefiles/Makefile.win.  But this change had no
> effect until I removed the line in backend/Makefile that also sets
> DLLLIB, hiding the value from Makefile.win.

Hm.  Clearly we should have only one definition, so I've applied your
patch.  But if the one in backend/Makefile was the controlling one,
shouldn't we make the entry in makefiles/Makefile.win match what was
in Makefile?  Seems like that is the value that's been tested so far.

            regards, tom lane

pgsql-ports by date:

Previous
From: Fred Yankowski
Date:
Subject: Re: patch for minor Win32 makefile bug
Next
From: Fred Yankowski
Date:
Subject: Re: [PATCHES] patch for minor Win32 makefile bug