Missing free_var() at end of accum_sum_final()? - Mailing list pgsql-hackers

From Joel Jacobson
Subject Missing free_var() at end of accum_sum_final()?
Date
Msg-id 35fb0533-1e3e-42f6-b989-ce1f9b5f3ebe@app.fastmail.com
Whole thread Raw
Responses Re: Missing free_var() at end of accum_sum_final()?
List pgsql-hackers
Hi,

I noticed the NumericVar's pos_var and neg_var are not free_var()'d at the end of accum_sum_final().

The potential memory leak seems small, since the function is called only once per sum() per worker (and from a few more places), but maybe they should be free'd anyways for correctness?

/Joel

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: remove duplicate comment.
Next
From: Thomas Munro
Date:
Subject: Re: Dead code in ps_status.c