Re: Cleanup: remove unused fields from nodes - Mailing list pgsql-hackers

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Apr 23, 2024 at 01:01:04PM -0400, Tom Lane wrote:
>> That is, query jumbling no longer distinguishes "DEALLOCATE x" from
>> "DEALLOCATE ALL", because the DeallocateStmt.name field is marked
>> query_jumble_ignore.  Now maybe that's fine, but it's a point
>> we'd not considered so far in this thread.  Thoughts?

> And of course, I've managed to forget about bb45156f342c and the
> reason behind the addition of the field is to be able to make the
> difference between the named and ALL cases for DEALLOCATE, around
> here:
> https://www.postgresql.org/message-id/ZNq9kRwWbKzvR%2B2a%40paquier.xyz

Hah.  Seems like the comment for isall needs to explain that it
exists for this purpose, so we don't make this mistake again.

            regards, tom lane