Re: [HACKERS] "make check" with non-GNU make - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] "make check" with non-GNU make
Date
Msg-id 3593.1502292334@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] "make check" with non-GNU make  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Wed, Aug 9, 2017 at 3:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, looking into Makefile.global.in, that step seems to be conditional on
>> MAKELEVEL:

> Ah, right.  That coding is recommended in the GNU make manual to
> distinguish from explicit invocation and recursive invocation.
> FreeBSD make also seems to set MAKELEVEL.

Oh, that would do it.

> Doing this fixes the
> problem for me, though it feels a bit sneaky:

> -          $${GMAKE} $@ ; \
> +          MAKELEVEL= $${GMAKE} $@ ; \

Seems like a reasonable fix to me.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recentlyadded wait events
Next
From: Ildus Kurbangaliev
Date:
Subject: Re: [HACKERS] Remove 1MB size limit in tsvector