Re: [HACKERS] Remove 1MB size limit in tsvector - Mailing list pgsql-hackers

From Ildus Kurbangaliev
Subject Re: [HACKERS] Remove 1MB size limit in tsvector
Date
Msg-id 20170809182553.4704779e@wp.localdomain
Whole thread Raw
In response to Re: [HACKERS] Remove 1MB size limit in tsvector  (Torsten Zuehlsdorff <mailinglists@toco-domains.de>)
List pgsql-hackers
On Wed, 9 Aug 2017 09:01:44 +0200
Torsten Zuehlsdorff <mailinglists@toco-domains.de> wrote:

> On 01.08.2017 22:00, Ildus K wrote:
> > On Tue, 1 Aug 2017 15:33:08 -0400
> > Robert Haas <robertmhaas@gmail.com> wrote:
> >   
> >> On Tue, Aug 1, 2017 at 3:10 PM, Ildus K
> >> <i.kurbangaliev@postgrespro.ru> wrote:  
> >>>> So this would break pg_upgrade for tsvector columns?  
> >>>
> >>> I added a function that will convert old tsvectors on the fly.
> >>> It's the approach used in hstore before.  
> >>
> >> Does that mean the answer to the question that I asked is "yes,
> >> but I have a workaround" or does it mean that the answer is "no"?
> >>  
> > 
> > It's a workaround. DatumGetTSVector and
> > DatumGetTSVectorCopy will upgrade tsvector on the fly if it
> > has old format.  
> 
> I'm not familiar with pg_upgrade, but want to ask: should this 
> workaround be part of pg_upgrade?
> 
> Greetings,
> Torsten

I chose the way when the data remains the same, until the user decides
to update it. I'm not so familiar with pg_upgrade myself and I don't
see now how the data will be converted with it, but it will anyway
increase downtime which is the shorter the better.

-- 
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] "make check" with non-GNU make
Next
From: Shubham Barai
Date:
Subject: Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)