Re: PG_TEST_EXTRA and meson - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PG_TEST_EXTRA and meson
Date
Msg-id 3573037.1721239891@sss.pgh.pa.us
Whole thread Raw
In response to Re: PG_TEST_EXTRA and meson  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: PG_TEST_EXTRA and meson
List pgsql-hackers
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> On Wed, Jul 17, 2024 at 8:01 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The existing and documented expectation is that PG_TEST_EXTRA is an
>> environment variable, ie it's a runtime option not a configure option.
>> Making it be the latter seems like a significant loss of flexibility
>> to me.

> I think/hope we're saying the same thing -- developers should not be
> forced to lock PG_TEST_EXTRA into their configurations; that's
> inflexible and unhelpful.

Indeed.

> What I'm saying in addition to that is, I really like that I can
> currently put a default PG_TEST_EXTRA into my meson config so that I
> don't have to keep track of it, and I do that all the time. So I'm in
> favor of the "option 3" approach.

Ah.  I have no particular objection to that, but I wonder whether
we should make the autoconf/makefile infrastructure do it too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CI, macports, darwin version problems
Next
From: Nathan Bossart
Date:
Subject: Re: improve performance of pg_dump with many sequences