Re: New FSM patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: New FSM patch
Date
Msg-id 3552.1221224248@sss.pgh.pa.us
Whole thread Raw
In response to Re: New FSM patch  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: New FSM patch
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> Let me describe this test case first:
> - The test program calls RecordAndGetPageWithFreeSpace in a tight loop, 
> with random values.

What's the distribution of the random values, exactly?  In particular,
how do the request sizes compare to available free space per-page?

The design intent for FSM was that we'd not bother to record pages that
have less free space than the average request size, so as to (usually)
avoid the problem of uselessly searching a lot of entries.  I can't tell
whether your test case models that behavior at all.  If it does then
there may be something else that needs fixing.
        regards, tom lane


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Better auth errors from libpq
Next
From: Heikki Linnakangas
Date:
Subject: Re: Synchronous Log Shipping Replication