Re: BUG #17462: Invalid memory access in heapam_tuple_lock - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #17462: Invalid memory access in heapam_tuple_lock
Date
Msg-id 352840.1649699498@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #17462: Invalid memory access in heapam_tuple_lock  (Andres Freund <andres@anarazel.de>)
Responses Re: BUG #17462: Invalid memory access in heapam_tuple_lock  (Andres Freund <andres@anarazel.de>)
List pgsql-bugs
Andres Freund <andres@anarazel.de> writes:
> One way to address it in a way not requiring an API break would be to pass
> SnapshotAny to heap_fetch and then do an explicit visibility check "ourselves"
> in heapam_lock_tuple().

I'm not really interested in fixing this without an API break (going
forward anyway), because as it stands heap_fetch is just an invitation
to make this same mistake again.  It should never return a tuple pointer
if we don't keep the pin on the associated buffer.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #17462: Invalid memory access in heapam_tuple_lock
Next
From: Andres Freund
Date:
Subject: Re: BUG #17462: Invalid memory access in heapam_tuple_lock