Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Oops, don't forget to rewind the directory before scanning it to - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Oops, don't forget to rewind the directory before scanning it to
Date
Msg-id 3507.1266805858@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Oops, don't forget to rewind the directory before scanning it to  (stark@postgresql.org (Greg Stark))
List pgsql-committers
Tree view 
stark@postgresql.org (Greg Stark) writes:
> Oops, don't forget to rewind the directory before scanning it to fsync files in CREATE DATABASE

This is certainly not right:

+     AllocateDir(fromdir);
      if (xldir == NULL)
          ereport(ERROR,

There's no guarantee AllocateDir will hand back the same pointer as
it did the previous time.

            regards, tom lane

pgsql-committers by date:

Previous
From: Greg Stark
Date:
Subject: Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Oops, don't forget to rewind the directory before scanning it to