Re: Miscellaneous changes to plperl [PATCH] - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Miscellaneous changes to plperl [PATCH]
Date
Msg-id 34d269d41001231738n3cc9380dw9f037ec5e1bd5183@mail.gmail.com
Whole thread Raw
In response to Re: Miscellaneous changes to plperl [PATCH]  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Sat, Jan 23, 2010 at 16:26, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> Tim Bunce wrote:
>>>
>>> -   } keys %$imports;
>>> +   } sort keys %$imports;
>>>
>>
>> Ok, good.
>>
>>
>>>
>>> -   my $funcsrc;
>>> -   $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog
>>> $src } ];
>>> -   #warn "plperl mkfuncsrc: $funcsrc\n";
>>> -   return $funcsrc;
>>> +   return qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src }
>>> ];
>>>
>>>
>>
>> Ok. (I don't think that'll clash with any later patches.)
>>
>>
>> So, what now? Should I resend the patch with the two 'ok' changes above
>> included, or can the committer make those very minor changes?
>>
>>
>>
>
> I'll pick these up, if Alex marks it ready for committer.

Done.


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: restructuring "alter table" privilege checks (was: remove redundant ownership checks)
Next
From: Alex Hunsaker
Date:
Subject: Re: Miscellaneous changes to plperl [PATCH]