Re: BUG #17774: Assert triggered on brin_minmax_multi.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #17774: Assert triggered on brin_minmax_multi.c
Date
Msg-id 3485884.1675868581@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #17774: Assert triggered on brin_minmax_multi.c  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: BUG #17774: Assert triggered on brin_minmax_multi.c
List pgsql-bugs
Dmitry Dolgov <9erthalion6@gmail.com> writes:
> The negative delta might be only a consequence. From what I see it's
> called from build_distances, and the idea is to find the gaps between
> the max value of the current interval and the min value of the next one,
> so they should be ordered and delta should be always positive.

I'd believe this argument more readily if the calculation weren't being
done in float arithmetic.  Since it is, you're at the mercy of roundoff
error ... and that small negative delta could certainly pass for
roundoff error.

Clamping the result to [0,1] would be a brighter plan than just asserting
that it's in-range.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: BUG #17774: Assert triggered on brin_minmax_multi.c
Next
From: Dmitry Dolgov
Date:
Subject: Re: BUG #17774: Assert triggered on brin_minmax_multi.c