Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function - Mailing list pgsql-general

From Tom Lane
Subject Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function
Date
Msg-id 3446817.1711575877@sss.pgh.pa.us
Whole thread Raw
In response to Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function  (Jeff Ross <jross@openvistas.net>)
Responses Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function
List pgsql-general
Jeff Ross <jross@openvistas.net> writes:
> I only use one plpython3u cursor in that function.  The plpython docs say:

> "Cursors are automatically disposed of. But if you want to explicitly 
> release all resources held by a cursor, use the |close| method. Once 
> closed, a cursor cannot be fetched from anymore."

> https://www.postgresql.org/docs/15/plpython-database.html#id-1.8.11.14.3

> Perhaps "pinned" in the error message means "open"?

No, it means "pinned" ... but I see that plpython pins the portal
underlying any PLyCursor object it creates.  Most of our PLs do
that too, to prevent a portal from disappearing under them (e.g.
if you were to try to close the portal directly from SQL rather
than via whatever mechanism the PL wants you to use).

> I added a cursor.close() as the last line called in that function and it 
> works again.

It looks to me like PLy_cursor_close does pretty much exactly the same
cleanup as PLy_cursor_dealloc, including unpinning and closing the
underlying portal.  I'm far from a Python expert, but I suspect that
the docs you quote intend to say "cursors are disposed of when Python
garbage-collects them", and that the reason your code is failing is
that there's still a reference to the PLyCursor somewhere after the
plpython function exits, perhaps in a Python global variable.

            regards, tom lane



pgsql-general by date:

Previous
From: Jeff Ross
Date:
Subject: Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function
Next
From: Jeff Ross
Date:
Subject: Re: After 10 -> 15 upgrade getting "cannot commit while a portal is pinned" on one python function