Re: Feedback on getting rid of VACUUM FULL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Feedback on getting rid of VACUUM FULL
Date
Msg-id 3409.1253147817@sss.pgh.pa.us
Whole thread Raw
In response to Re: Feedback on getting rid of VACUUM FULL  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Feedback on getting rid of VACUUM FULL
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> For the kicks, I looked at what it would take to write a utility like
> that. It turns out to be quite trivial, patch attached.

I don't think you've really thought this through; particularly not this:

> +    rel = heap_open(relid, AccessShareLock);

You can NOT modify a relation with only AccessShareLock, and frankly
I doubt you should be doing this with less than exclusive lock.  Which
would make the thing quite unpleasant to use in practice.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PATCH: make plpgsql IN args mutable (v1) [REVIEW]
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] pgbench: new feature allowing to launch shell commands