Re: PXGS vs TAP tests - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: PXGS vs TAP tests
Date
Msg-id 33c29638-5037-6a20-a46a-d802c4b2f67e@dunslane.net
Whole thread Raw
In response to Re: PXGS vs TAP tests  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: PXGS vs TAP tests
List pgsql-hackers
On 6/20/21 10:56 AM, Andrew Dunstan wrote:
> On 6/20/21 10:45 AM, Tom Lane wrote:
>
>>> I removed the REGRESS_SHLIB setting altogether for the PGXS case - it's
>>> not clear to me why we need it in a TAP test recipe at all.
>> After some digging in the git history, it looks like it's there because
>> of Noah's c09850992, which makes me wonder whether 017_shm.pl requires
>> it.  If so, it'd make more sense perhaps for that one test script
>> to set up the environment variable than to have it cluttering every TAP
>> run.
>
> Yeah, I'll do some testing.
>
>
>

Tests pass with the attached patch, which puts the setting in the
Makefile for the recovery tests. The script itself doesn't need any
changing.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com


Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Race condition in InvalidateObsoleteReplicationSlots()
Next
From: Andrey Borodin
Date:
Subject: Re: Different compression methods for FPI