Hello Tom,
01.03.2025 20:04, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> It looks like 8f427187d broke pg_dump on Cygwin:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2025-02-26%2010%3A03%3A07
> Yeah, Andrew and I have been puzzling over that off-list. pg_dump
> is definitely exiting unceremoniously.
>
>> As far as I can see, it exits prematurely here:
>> float reltuples = strtof(PQgetvalue(res, i, i_reltuples), NULL);
> I was suspecting those float conversions as a likely cause, but
> what do you think is wrong exactly? I see nothing obviously
> buggy in pg_strtof().
From my understanding, pg_strtof () can't stand against endptr == NULL.
I have changed that line to:
char *tptr;
float reltuples = strtof(PQgetvalue(res, i, i_reltuples), &tptr);
and 002_compare_backups passed for me.
Best regards,
Alexander Lakhin
Neon (https://neon.tech)
