Re: log_min_duration_statement feature - Mailing list pgsql-patches

From Tom Lane
Subject Re: log_min_duration_statement feature
Date
Msg-id 3364.1051026751@sss.pgh.pa.us
Whole thread Raw
In response to log_min_duration_statement feature  (Christopher Kings-Lynne <chriskl@familyhealth.com.au>)
List pgsql-patches
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> The only thing that I'm not 100% on is the ong >= int * 1000 comparison I
> do - will that overflow if the user has supplied max int?

Yes.  Consider declaring the "max value" in the GUC variable's info block
as INT_MAX/1000 instead of INT_MAX.

(We should go through all of the GUC variables with an eye to places
where the max value is unrealistically high, but for the moment I'll
settle for not introducing any new sillinesses ...)

            regards, tom lane


pgsql-patches by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: log_min_duration_statement feature
Next
From: Michael Graff
Date:
Subject: Re: IPv6 address parsing for inet/cidr types (take II)