Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> The only thing that I'm not 100% on is the ong >= int * 1000 comparison I
> do - will that overflow if the user has supplied max int?
Yes. Consider declaring the "max value" in the GUC variable's info block
as INT_MAX/1000 instead of INT_MAX.
(We should go through all of the GUC variables with an eye to places
where the max value is unrealistically high, but for the moment I'll
settle for not introducing any new sillinesses ...)
regards, tom lane