Re: EquivalenceClass and custom_read_write - Mailing list pgsql-hackers

From Tom Lane
Subject Re: EquivalenceClass and custom_read_write
Date
Msg-id 3352736.1739379345@sss.pgh.pa.us
Whole thread Raw
In response to EquivalenceClass and custom_read_write  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: EquivalenceClass and custom_read_write
List pgsql-hackers
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
> In pathnodes.h
> typedef struct EquivalenceClass
> {
> pg_node_attr(custom_read_write, no_copy_equal, no_read, no_query_jumble)

> Because of custom_read_write attribute, I expect _outEquivalenceClass
> to be present in outfuncs.c and _readEquivalenceClass to be present in
> readfuncs.c. I find the first but not the second. This could be
> because _out function is only for debugging and what it writes is
> never read back. Should we add a comment in EquivalenceClass prologue
> mentioning the same?

Doesn't the "no_read" annotation imply exactly that?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Small memory fixes for pg_createsubcriber
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: TAP test command_fails versus command_fails_like