Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers
Date
Msg-id 3316.1365524883@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> I kind of wonder if there's some way we could split ProcessUtility()
> up into more digestible pieces.  I can't really think of a good way to
> do it though, without writing duplicative switches.

I'm thinking a bit about

    ProcessUtility()
    {
        switch (tag)
        {
            ... cases for BEGIN etc ...
            default:
                ProcessSlowUtility(...)
        }
    }

    ProcessSlowUtility()
    {
        event setup code
        switch (tag)
        {
            ... cases for everything else ...
            default:
                elog(ERROR)
        }
        event teardown code
    }

            regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: [COMMITTERS] pgsql: Add sql_drop event for event triggers
Next
From: "Joshua D. Drake"
Date:
Subject: Re: page 1 of relation global/11787 was uninitialized