Re: [PATCH] inet << indexability - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] inet << indexability
Date
Msg-id 3302.992717008@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] inet << indexability  (Alex Pilosov <alex@pilosoft.com>)
Responses Re: [PATCH] inet << indexability  (Alex Pilosov <alex@pilosoft.com>)
List pgsql-hackers
Alex Pilosov <alex@pilosoft.com> writes:
> I didn't want to make them user-visible, however, the alternative, IMHO,
> is worse, since these functions rely on network_broadcast and
> network_network to do the work, calling sequence would be:
> a) indxpath casts Datum to inet, passes to network_scan*
> b) network_scan will create new Datum, pass it to network_broadcast
> c) network_scan will extract inet from Datum returned
> d) indxpath will then cast inet back to Datum :)
> Which, I think, is pretty messy :)

Sure, but you could make them look like
Datum network_scan_first(Datum networkaddress)

without incurring any of that overhead.  (Anyway, Datum <-> inet* is
only a cast.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alex Pilosov
Date:
Subject: Re: [PATCH] inet << indexability
Next
From: Alex Pilosov
Date:
Subject: Re: [PATCH] inet << indexability