Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ... - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ...
Date
Msg-id 3293.1029597297@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server/src/interfaces/libpgtcl pgtclCmds ...  (momjian@postgresql.org (Bruce Momjian - CVS))
Responses Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ...  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-committers
momjian@postgresql.org (Bruce Momjian - CVS) writes:
>     Everytime if I do PQconsumeInput (when the backend channel gets
>     readable) I check for the return value. (0 == error) and generate a
>     notification manually, e.g. fixed string connection_closed) and pass it to the
>     TCL event queue.

Was that patch reviewed by anyone?  I don't think I've even seen it
successfully posted --- the submitter seemed to be having trouble
attaching it.

From the description, I don't think I trust it much.  Event queue stuff
is subtle ...

>   The only other thing I had to do is to comment out removing
>     all pending events in PgStopNotifyEventSource whenever the connection was
>     unexpectedly closed (so the manually generated event will not be deleted).

... and this is *very* likely to break things.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian - CVS)
Date:
Subject: pgsql-server/src backend/access/transam/xlog.c ...
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql-server/src/interfaces/libpgtcl pgtclCmds ...