Re: pgsql: libpq: Notice errors a backend may have sent just before dying. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: libpq: Notice errors a backend may have sent just before dying.
Date
Msg-id 32700.1447338569@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: libpq: Notice errors a backend may have sent just before dying.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: libpq: Notice errors a backend may have sent just before dying.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> libpq: Notice errors a backend may have sent just before dying.
> At least since the introduction of Hot Standby, the backend has
> sometimes sent fatal errors even when no client query was in
> progress, assuming that the client would receive it.  However,
> pqHandleSendFailure was not in sync with this assumption, and
> only tries to catch notices and notifies.  Add a parseInput call
> to the loop there to fix.

Just for the record, this patch changes no behavior whatsoever.
It could only make a difference if the backend were still actively
sending data, which certainly isn't so in the case claimed by the
commit message.  Moreover, removing the comment that explains why
only NOTICE and NOTIFY messages will be eaten doesn't make it not so.

            regards, tom lane


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: libpq: Notice errors a backend may have sent just before dying.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: libpq: Notice errors a backend may have sent just before dying.