Postgres Pro
Downloads
Home   >   mailing lists

Re: Code cleanup for build_regexp_split_result - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Code cleanup for build_regexp_split_result
Date
Msg-id 32668.1579192424@sss.pgh.pa.us
Whole thread Raw
In response to Code cleanup for build_regexp_split_result  (Li Japin <japinli@hotmail.com>)
List pgsql-hackers
Tree view 
Li Japin <japinli@hotmail.com> writes:
> I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we?

Hm, yeah, that looks a bit strange.  It was less strange before
c8ea87e4bd950572cba4575e9a62284cebf85ac5, I think.

Pushed with some additional simplification to get rid of the
rather ugly (IMO) PG_USED_FOR_ASSERTS_ONLY variable.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: SlabCheck leaks memory into TopMemoryContext
Next
From: Tom Lane
Date:
Subject: Re: SlabCheck leaks memory into TopMemoryContext