Re: FETCH FIRST clause WITH TIES option - Mailing list pgsql-hackers

From Tom Lane
Subject Re: FETCH FIRST clause WITH TIES option
Date
Msg-id 32413.1554318485@sss.pgh.pa.us
Whole thread Raw
In response to Re: FETCH FIRST clause WITH TIES option  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: FETCH FIRST clause WITH TIES option
List pgsql-hackers
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> I've tried to fix the merge conflict (essentially by moving some of the
> code to adjust_limit_rows_costs(), but I'm wondering if the code added to
> create_limit_path is actually correct
> ...
> Firstly, this seriously needs some comment explaining why we do this.

I've not looked at this patch, but TBH I wonder why it is touching
planner rowcount estimation at all.  I find it doubtful either that
a correction for WITH TIES would be significant in most use-cases,
or that we could estimate it accurately if it was significant.
It certainly doesn't seem like something that needs to be messed
with in v1 of the feature.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: FETCH FIRST clause WITH TIES option
Next
From: Tomas Vondra
Date:
Subject: Re: FETCH FIRST clause WITH TIES option