Re: unused/redundant foreign key code - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: unused/redundant foreign key code
Date
Msg-id 322A3C3B-C336-4A26-BC5F-A1CD70192B1C@yesql.se
Whole thread Raw
In response to unused/redundant foreign key code  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: unused/redundant foreign key code
List pgsql-hackers
> On 8 Aug 2018, at 21:34, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> I found some unused and some redundant code in ri_triggers.c that was
> left around by some previous changes that aimed to optimize away certain
> trigger invocations.  See attached patches.

Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.

From reading code and testing, I concur with your findings that this is indeed
dead code.

+1 on this cleanup, I’m marking this as Ready for Committer.

cheers ./daniel

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: repeated procedure call error
Next
From: Jürgen Strobel
Date:
Subject: Re: BUG #15212: Default values in partition tables don't work asexpected and allow NOT NULL violation