Re: evtcache: EventTriggerCache vs Event Trigger Cache - Mailing list pgsql-hackers

From Tom Lane
Subject Re: evtcache: EventTriggerCache vs Event Trigger Cache
Date
Msg-id 3195699.1683202152@sss.pgh.pa.us
Whole thread Raw
In response to evtcache: EventTriggerCache vs Event Trigger Cache  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: evtcache: EventTriggerCache vs Event Trigger Cache
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> When reading a memory contexts log I realized that we have this:
> LOG:  level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4 chunks); 264 used
> LOG:  level: 3; Event Trigger Cache: 8192 total in 1 blocks; 2616 free (0 chunks); 5576 used

> The reason is that BuildEventTriggerCache sets up a context "EventTriggerCache"
> which house a hash named "Event Trigger Cache" which in turn creates a context
> with the table name.  I think it makes sense that these share the same name,
> but I think it would be less confusing if they also shared the same spelling
> whitespace-wise.  Any reason to not rename the hash EventTriggerCache to make
> the logging a tiny bit easier to read and grep?

Hmm, I'm kinda -1 on them having the same name visible in the
contexts dump --- that seems very confusing.  How about naming
the hash "EventTriggerCacheHash" or so?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: evtcache: EventTriggerCache vs Event Trigger Cache
Next
From: Tom Lane
Date:
Subject: Re: "CREATE RULE ... ON SELECT": redundant?