Re: Idea for improving buildfarm robustness - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Idea for improving buildfarm robustness
Date
Msg-id 319.1443553624@sss.pgh.pa.us
Whole thread Raw
In response to Re: Idea for improving buildfarm robustness  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Idea for improving buildfarm robustness  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> I wouldn't want to do this every time through the postmaster's main loop,
>> but we could do this once an hour for no added cost by adding the check
>> where it does TouchSocketLockFiles; or once every few minutes if we
>> carried a separate variable like last_touch_time.  Once an hour would be
>> plenty to fix the buildfarm's problem, I should think.

> I have a bad (?) habit of doing exactly this during development and
> would really like it to be a bit more often than once/hour, unless
> there's a particular problem with that.  

Yeah, Josh mentioned the same.  It would only take another three or four
lines of code to decouple it from TouchSocketLockFiles, and then it's
just a question of how much are you worried about the performance cost of
additional file-open attempts.  I think either one-minute or five-minute
intervals would be pretty defensible.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Idea for improving buildfarm robustness
Next
From: Andrew Dunstan
Date:
Subject: Re: Idea for improving buildfarm robustness