I wrote:
> Patch 0002 deprecates CREATE MATERIALIZED VIEW IF NOT EXISTS because it
> no longer seems necessary with patch 0001. Tom Lane commented[1] about
> the general dislike of IF NOT EXISTS, to which I agree, but maybe this
> was meant only in response to adding new commands.
One could also argue that since matviews are a hybrid of tables and
views, that CREATE MATERIALIZED VIEW should accept both OR REPLACE (as
in CREATE VIEW) and IF NOT EXISTS (as in CREATE TABLE). But not in the
same invocation of course.
On 2024-07-02 12:46 +0200, Aleksander Alekseev wrote:
> > Anyway, my idea is to deprecate that usage in PG18 and eventually
> > remove it in PG19, if there's consensus for it. We can drop that
> > clause without violating any standard because matviews are a
> > Postgres extension. I'm not married to the idea, just want to put
> > it on the table for discussion.
>
> I can imagine how this may impact many applications and upset many
> software developers worldwide. Was there even a precedent (in the
> recent decade or so) when PostgreSQL broke the SQL syntax?
A quick spelunking through the changelog with
git log --grep deprecat -i --since '10 years ago'
turned up two commits:
578b229718 "Remove WITH OIDS support, change oid catalog column visibility."
e8d016d819 "Remove deprecated COMMENT ON RULE syntax"
Both were committed more than 10 years after deprecating the respective
feature. My proposed one-year window seems a bit harsh in comparison.
On 2024-07-02 14:27 +0200, Daniel Gustafsson wrote:
> Considering the runway we typically give for deprecations, that seems like a
> fairly short timeframe for a SQL level command which isn't unlikely to exist
> in application code.
Is there some general agreed upon timeframe, or is decided on a
case-by-case basis? I can imagine waiting at least until the last
release without the deprecation reaches EOL. That would be 5 years with
the current versioning policy.
--
Erik
