Re: No error checking when reading from file using zstd in pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: No error checking when reading from file using zstd in pg_dump
Date
Msg-id 3167013.1751384548@sss.pgh.pa.us
Whole thread Raw
In response to Re: No error checking when reading from file using zstd in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> In preparing for concluding this I've attached a v8 which is the patchset in v7
> squashed into a single commit with an attempt at a commit message.

Glancing through this, I observe a couple of minor typos:

+     * Returns number of bytes read (this might be less than 'size' if EOF was
+     * reached).  Exits via pg_fatal all for error conditions.

s/all for/for all/

+        pg_fatal("coud not write to file: %m");

s/coud/could/

There are some minor typos in the proposed commit message, too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: back-patch documentation for age() and mxid_age()
Next
From: Bertrand Drouvot
Date:
Subject: Re: Add os_page_num to pg_buffercache