Re: Return value of PathNameOpenFile() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Return value of PathNameOpenFile()
Date
Msg-id 3149754.1662473562@sss.pgh.pa.us
Whole thread Raw
In response to Re: Return value of PathNameOpenFile()  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Return value of PathNameOpenFile()
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> Agreed, zero should be valid as it's a non-negative integer.  However, callers
> in fd.c are themselves checking for (fd <= 0) in some cases, and some have done
> so since the very early days of the codebase, so I wonder if there historically
> used to be a platform which considered 0 an invalid fd?

I'm betting it's a thinko that never got caught because 0 would
always be taken up by stdin.  Maybe you'd notice if you tried to
close-and-reopen stdin, but that's not something the server ever does.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Next
From: Tom Lane
Date:
Subject: Re: (doc patch) psql version compatibility