Re: relcache reference leak on refresh materialized view concurrently - Mailing list pgsql-bugs

From Tom Lane
Subject Re: relcache reference leak on refresh materialized view concurrently
Date
Msg-id 31494.1395086407@sss.pgh.pa.us
Whole thread Raw
In response to relcache reference leak on refresh materialized view concurrently  (yamamoto@valinux.co.jp (YAMAMOTO Takashi))
Responses Re: relcache reference leak on refresh materialized view concurrently  (yamamoto@valinux.co.jp (YAMAMOTO Takashi))
List pgsql-bugs
yamamoto@valinux.co.jp (YAMAMOTO Takashi) writes:
> the following patch fixes missing index_close in case
> the mv has non-unique indexes.

Hm ... I see the leak, I think, but isn't this an extraordinarily
complex patch?  Looks like adding

    else
    {
        index_close(indexRel, NoLock);
    }

at the bottom of the "if" would also fix the problem, and would be
far easier to verify.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Jeff Frost
Date:
Subject: Re: BUG #9606: pg_class relhaspkey column not updated on removal of primary key
Next
From: Noah Misch
Date:
Subject: Re: BUG #9472: pg_dumpall fails with "unrecognized node type: 650"