Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Date
Msg-id 31479.1460152130@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On 01/22/2016 03:46 PM, Tom Lane wrote:
>> Add trigonometric functions that work in degrees.

> I have a host here that is having regression test failures from this commit:

> --- src/test/regress/expected/float8.out
> +++ src/test/regress/results/float8.out
> @@ -490,9 +490,9 @@
>     x   | asind | acosd | atand
>   ------+-------+-------+-------
>      -1 |   -90 |   180 |   -45
> - -0.5 |   -30 |   120 |
> + -0.5 |       |   120 |
>       0 |     0 |    90 |     0
> -  0.5 |    30 |    60 |
> +  0.5 |       |    60 |
>       1 |    90 |     0 |    45
>   (5 rows)

BTW ... looking closer at that, it appears to show asind(-0.5) and
asind(0.5) returning NULL.  Which makes no sense at all, because
there is no provision in dasind() for returning a null, regardless
of the input value.

So I'm pretty baffled.  Maybe you could step through this and figure
out where it's going off the rails?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Default Roles (was: Additional role attributes)
Next
From: Kevin Grittner
Date:
Subject: Re: [COMMITTERS] pgsql: Add the "snapshot too old" feature