Re: Trouble with hashagg spill I/O pattern and costing - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Trouble with hashagg spill I/O pattern and costing
Date
Msg-id 312bf7eb53b0b9f953e4eb0c704ed4f2121bce4d.camel@j-davis.com
Whole thread Raw
In response to Re: Trouble with hashagg spill I/O pattern and costing  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
On Fri, 2020-05-29 at 15:04 +0200, Tomas Vondra wrote:
> Ah, right. Yeah, we only need to check for AGG_HASH here. Moreover,
> AGG_MIXED probably does not need the tlist tweak, because the input
> should be pre-sorted as with AGG_SORTED.
> 
> And we should probably do similar check in the
> create_groupinsets_path,
> I guess. At first I thought we can't do that before inspecting
> rollups,
> which only happens later in the function, but now I see there's
> aggstrategy in GroupingSetsPath too.

Looks good.

    Jeff





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pie-in-sky idea: 'sensitive' function parameters
Next
From: Martín Marqués
Date:
Subject: Re: Read access for pg_monitor to pg_replication_origin_status view