Re: BUG #15539: Deadcode in OpenTableList - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #15539: Deadcode in OpenTableList
Date
Msg-id 30955.1544198659@sss.pgh.pa.us
Whole thread Raw
In response to BUG #15539: Deadcode in OpenTableList  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
=?utf-8?q?PG_Bug_reporting_form?= <noreply@postgresql.org> writes:
> The function OpenTableList performs the condition check " if
> (list_member_oid(relids, childrelid))" twice. The second condition will
> always evaluate to FALSE. As a result, the code (i.e., heap_close) on the
> true branch of the second condition check is deadcode.

Yeah, you're right.  I wonder whether we should've expected Coverity
to notice that.

Fix pushed, thanks for the report!

            regards, tom lane


pgsql-bugs by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: BUG #15542: value too long for type character varying does not show the real parameter value
Next
From: Tom Lane
Date:
Subject: Re: BUG #15540: Use after release in ExecuteTruncateGuts