Re: lock_timeout GUC patch - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: lock_timeout GUC patch
Date
Msg-id 3073cc9b1001122214r23ed7e9co34e30fbf073d8b17@mail.gmail.com
Whole thread Raw
In response to Re: lock_timeout GUC patch  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: lock_timeout GUC patch  (Boszormenyi Zoltan <zb@cybertec.at>)
Re: lock_timeout GUC patch  (Boszormenyi Zoltan <zb@cybertec.at>)
List pgsql-hackers
2010/1/13 Boszormenyi Zoltan <zb@cybertec.at>:
> Tom Lane írta:
>>
>> If this patch is touching those parts of relcache.c, it probably needs
>> rethinking.
>>
>
> What I did there is to check the return value of LockRelationOid()

the hunk was because a diference in the position (i guess patch accept
a hunk of reasonable size, assuming there is something like a
reasonable size for that)

and is not touching the same as your refactor (sorry if i explain myself bad)

> and also elog(PANIC) if the lock wasn't available.
> Does it need rethinking?
>

well, i actually think that PANIC is too high for this...

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157


pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: lock_timeout GUC patch
Next
From: Michael Meskes
Date:
Subject: Re: ECPG patch causes warning