Re: [PATCHES] Solve a problem of LC_TIME of windows. - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: [PATCHES] Solve a problem of LC_TIME of windows.
Date
Msg-id 3073cc9b0811232013q1a295432o1ec582b87a89ecc9@mail.gmail.com
Whole thread Raw
In response to Re: [PATCHES] Solve a problem of LC_TIME of windows.  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
List pgsql-hackers
On Sun, Nov 16, 2008 at 8:36 AM, Hiroshi Saito <z-saito@guitar.ocn.ne.jp> wrote:
> Hi.
>
> Then, It continues and a review is desired. Thanks!
>

In http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx says:
"""
Return Value
strftime returns the number of characters placed in strDest and
wcsftime returns the corresponding number of wide characters.
If the total number of characters, including the terminating null, is
more than maxsize, both strftime and wcsftime return 0 and the
contents of strDest is indeterminate.
"""

If i'm reading it right, the patch should contain something like:

if (len > dstlen)
{   return 0;
}

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157


pgsql-hackers by date:

Previous
From: "Matthew T. O'Connor"
Date:
Subject: Re: Visibility map, partial vacuums
Next
From: "Hiroshi Saito"
Date:
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows.