Re: JIT: The nullness of casetest.value can be determined at the JIT compile time. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: JIT: The nullness of casetest.value can be determined at the JIT compile time.
Date
Msg-id 3070951.1738207772@sss.pgh.pa.us
Whole thread Raw
In response to Re: JIT: The nullness of casetest.value can be determined at the JIT compile time.  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Huge +1 for cleaning up this abuse of caseValue_datum/domainValue_datum. 
> While correct and sensible if we continue the abuse, these patches feel 
> like putting lipstick on a pig.

Agreed.  I spent some time trying to do it better, with results
shown at [1].  If we adopt that idea, then the executor's support
for CaseTestExpr will go away, so there's little point in pursuing
that half of the patch given here.  However, I concluded that there's
insufficient reason to redesign CoerceToDomainValue, so we could
still push forward with that half of this patch.

            regards, tom lane

[1] https://www.postgresql.org/message-id/3068812.1738206654@sss.pgh.pa.us



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Getting rid of CaseTestExpr (well, partially)
Next
From: Mark Dilger
Date:
Subject: Re: Index AM API cleanup