Re: BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL
Date
Msg-id 3055350.1741962427@sss.pgh.pa.us
Whole thread Raw
In response to BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
PG Bug reporting form <noreply@postgresql.org> writes:
> Looks like there is inconsistency with 'ind_name' and 'int_type' checks. In
> one place both are checked. In other place only the second one is checked.
> It's possible that when the second is not NULL the first is also not NULL.
> If this is so then the problem is not real. But it's hard to prove this. In
> any case the code needs to be made more clear.

Perhaps it needs to be made more clear, but this patch seems like no
improvement.  Adding that Assert accomplishes nothing --- the code
will dump core if ind_name is null, with or without an Assert.

Given the lack of field complaints, I'm inclined to believe there's
not a bug here.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
Next
From: Viktor Holmberg
Date:
Subject: Re: ISN extension - wrong volatility level for isn_weak() function