pg_am.amstrategies should be 0 when not meaningful? - Mailing list pgsql-hackers

From Tom Lane
Subject pg_am.amstrategies should be 0 when not meaningful?
Date
Msg-id 304.1166286689@sss.pgh.pa.us
Whole thread Raw
Responses Re: pg_am.amstrategies should be 0 when not meaningful?
List pgsql-hackers
GIST and GIN currently set their amstrategies entries to 100, which is
a completely arbitrary number, since these index AMs don't impose any
particular interpretation on operator strategy numbers.  Usually it's
far too large and results in wasted space in relcache entries.  But it's
not impossible that it could be too small for a complex opclass.

I propose that we should set pg_am.amstrategies to zero when the index
AM doesn't have a fixed interpretation of strategy numbers.  This would
make it clearer that there's no intended upper bound.  It would also
cause the relcache not to bother trying to preload operator numbers,
which saves time and space --- neither of these AMs ever actually look
at the rd_operator array in relcache entries.

Comments?  Can anyone think of anything that is likely to break?
(I can only see one or two trivial code adjustments that would be
needed.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Operator class group proposal
Next
From: Joachim Wieland
Date:
Subject: Re: invalid input syntax for type timestamp.