Re: fix for BUG #3720: wrong results at using ltree - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fix for BUG #3720: wrong results at using ltree
Date
Msg-id 3007.1585605566@sss.pgh.pa.us
Whole thread Raw
In response to Re: fix for BUG #3720: wrong results at using ltree  (Nikita Glukhov <n.gluhov@postgrespro.ru>)
Responses Re: fix for BUG #3720: wrong results at using ltree  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Nikita Glukhov <n.gluhov@postgrespro.ru> writes:
> On 30.03.2020 21:00, Tom Lane wrote:
>> Hence, new patch versions that do it like that.  (0002 is unchanged.)

> I tried to simplify a bit loops in checkCond() by merging two of them into
> one with an explicit exit condition.  Also I added return statement after
> this loop, so it's now clear that we can't fall into next "while" loop.

I dunno, that doesn't really seem clearer to me (although some of it
might be that you expended no effort on making the comments match
the new code logic).

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nikita Glukhov
Date:
Subject: Re: fix for BUG #3720: wrong results at using ltree
Next
From: Ranier Vilela
Date:
Subject: Re: [PATCH] remove condition always true (/src/backend/access/heap/vacuumlazy.c)