Re: pg_dump: use ALTER TABLE for PKs - Mailing list pgsql-hackers

From Philip Warner
Subject Re: pg_dump: use ALTER TABLE for PKs
Date
Msg-id 3.0.5.32.20020220012335.01e51100@mail.rhyme.com.au
Whole thread Raw
In response to pg_dump: use ALTER TABLE for PKs  (Neil Conway <nconway@klamath.dyndns.org>)
Responses Re: pg_dump: use ALTER TABLE for PKs  (Philip Warner <pjw@rhyme.com.au>)
Re: pg_dump: use ALTER TABLE for PKs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
At 21:26 18/02/02 -0500, Neil Conway wrote:
>The patch is pretty simple, partly because the code was already there,
>just commented out ;-) I fixed a typo and added some comments.

When I originally wrote the commented-out code, we did not have the ability
to make 'dependant' TOC Entries, so it uses the OID of the index as the PK
OID in the ArchiveEntry call. 

I can't really think of a case where the index OID would be less than the
table OID, but it might be good to put the table OID in the deps list; this
will force the PK to go after the table in all cases. Did I mention I'm
paranoid?

It's also a first step in the ability to dump a 'whole table' Vs. just a
table definition - which we will need when all constraints can be dumped
via 'ALTER TABLE'.

For clarity, 'whole table' might mean the attrs, indexes, constraints,
triggers etc.


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|                                |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/


pgsql-hackers by date:

Previous
From: Vince Vielhaber
Date:
Subject: Re: www.postgresql.org 404 error...
Next
From: Philip Warner
Date:
Subject: Re: pg_dump: use ALTER TABLE for PKs