Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS
Date
Msg-id 2ffff2f9-8182-8ff2-0f29-15c61924a40e@2ndquadrant.com
Whole thread Raw
In response to Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS  (Craig Ringer <craig.ringer@enterprisedb.com>)
Responses Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS  (Craig Ringer <craig.ringer@enterprisedb.com>)
List pgsql-hackers
On 2021-01-06 00:30, Craig Ringer wrote:
> Perhaps debug_invalidate_system_caches_always ? It's a bit long but we 
> use the debug prefix elsewhere too.

Committed with that name.

In your original patch, this hunk in pg_config_manual.h:

+ * You can define these by editing pg_config_manual.h but it's usually
+ * sufficient to pass CFLAGS to configure, e.g.
+ *
+ *     ./configure --enable-debug --enable-cassert CFLAGS="-DUSE_VALGRIND"
+ *
+ * The flags are persisted in Makefile.global so they will be correctly
+ * applied to extensions, including those built by PGXS.

I don't think that necessarily works for all settings.  Maybe we should 
make a pass through it and ensure it all works sensibly, but that seems 
like a separate project.

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Single transaction in the tablesync worker?
Next
From: Michael Paquier
Date:
Subject: Re: Incorrect allocation handling for cryptohash functions with OpenSSL