Re: support for MERGE - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: support for MERGE
Date
Msg-id 2fcf717a-c542-466a-9031-d2c18206e5c2@www.fastmail.com
Whole thread Raw
In response to Re: support for MERGE  (Álvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: support for MERGE  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
On Mon, Mar 7, 2022, at 4:59 PM, Álvaro Herrera wrote:
I attach v13 here.  This version includes a 0002 that's does the split of nodeModifyTable.c routines, then 0003 implements MERGE on top of that.  0001 is as before.

In 0002, I've opted to have two separate structs.  One is the ModifyTableContext, as before, but I've removed 'tupleid' and 'oldtuple' (the specification of the tuple to delete/update) because it makes ExecCrossPartitionUpdate cleaner if we pass them separately.  The second struct is UpdateContext, which is used inside ExecUpdate as output data from its subroutines.  This is also for the benefit of cross-partition updates.

I'm pretty happy with how this turned out; even without considering MERGE, it seems to me that ExecUpdate benefits from being shorter.

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: role self-revocation
Next
From: Tom Lane
Date:
Subject: Re: Time to drop plpython2?