Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers. - Mailing list pgsql-committers

From Jeff Davis
Subject Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers.
Date
Msg-id 2f4ec2a4e20966474aabce0035ddf939af47fffc.camel@j-davis.com
Whole thread Raw
In response to Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Fri, 2023-06-16 at 18:06 -0400, Tom Lane wrote:
> You do not get to define that.  The reason we have buildfarm members
> running tests this way is exactly to flush out tests that are unduly
> collation-sensitive.  They will break in the field too.

It looks like the actual problem is that, when pg_regress creates the
database in --no-locale mode, it passes LC_COLLATE='C' and
LC_CTYPE='C', instead of just LOCALE='C'.

Before my commit, the two were equivalent so it didn't matter, but
afterwards it created an inconsistency that left daticulocale as cs-CZ.

Patch attached.

Regards,
    Jeff Davis


Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers.
Next
From: David Rowley
Date:
Subject: pgsql: Don't use partial unique indexes for unique proofs in the planne