Re: parallel.c is not marked as test covered - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: parallel.c is not marked as test covered
Date
Msg-id 2cf25a38-e2be-76a1-824e-6943ce345a44@2ndquadrant.com
Whole thread Raw
In response to Re: parallel.c is not marked as test covered  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: parallel.c is not marked as test covered  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 6/19/16 5:55 PM, Tom Lane wrote:
> Depending on what the percentage actually is, maybe we could treat
> this like the "random" test, and allow a failure to be disregarded
> overall?  But that doesn't seem very nice either, in view of our
> increasing reliance on automated testing.  If "random" were failing
> 90% of the time on some buildfarm critters, that would probably
> indicate a real problem, but we'd likely not realize it for a long time.

I think this test would only fail if it runs out of workers, and that 
would only happen in an installcheck run against a server configured in 
a nonstandard way or that is doing something else -- which doesn't 
happen on the buildfarm.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: primary_conninfo missing from pg_stat_wal_receiver
Next
From: Tom Lane
Date:
Subject: Re: parallel.c is not marked as test covered