Re: primary_conninfo missing from pg_stat_wal_receiver - Mailing list pgsql-hackers

From Tom Lane
Subject Re: primary_conninfo missing from pg_stat_wal_receiver
Date
Msg-id 14471.1466478375@sss.pgh.pa.us
Whole thread Raw
In response to Re: primary_conninfo missing from pg_stat_wal_receiver  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: primary_conninfo missing from pg_stat_wal_receiver  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 6/20/16 10:29 PM, Tom Lane wrote:
>> What I would want to know is whether this specific change is actually a
>> good idea.  In particular, I'm concerned about the possible security
>> implications of exposing primary_conninfo --- might it not contain a
>> password, for example?

> That would have been my objection.  This was also mentioned in the 
> context of moving recovery.conf settings to postgresql.conf, because 
> then the password would become visible in SHOW commands and the like.

> Alternatively or additionally, implement a way to strip passwords out of 
> conninfo information.  libpq already has information about which 
> connection items are sensitive.

Yeah, I'd been wondering whether we could parse the conninfo string into
individual fields and then drop the password field.  It's hard to see a
reason why this view needs to show passwords, since presumably everything
in it corresponds to successful connections --- if your password is wrong,
you aren't in it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Parallel query and temp_file_limit
Next
From: Peter Eisentraut
Date:
Subject: Re: parallel.c is not marked as test covered