Simplify event trigger support checking functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Simplify event trigger support checking functions
Date
Msg-id 2ce5758d-a1a8-bcc1-4bd7-381307cc6cbe@enterprisedb.com
Whole thread Raw
Responses Re: Simplify event trigger support checking functions
List pgsql-hackers
We have in event_trigger.c two functions 
EventTriggerSupportsObjectType() and EventTriggerSupportsObjectClass() 
that return whether a given object type/class supports event triggers. 
Maybe there was a real differentiation there once, but right now it 
seems to me that *all* object types/classes support event triggers, 
except: (1) shared objects and (2) event triggers themselves.  I think 
we can write that logic more explicitly and compactly and don't have to 
give the false illusion that there is a real choice to be made by the 
implementer here.

The only drawback in terms of code robustness is that someone adding a 
new shared object type would have to remember to add it to 
EventTriggerSupportsObjectType().  Maybe we could add a "object type is 
shared" function somehow, similar to IsSharedRelation(), to make that 
easier.  OTOH, someone doing that would probably go around and grep for, 
say, OBJECT_TABLESPACE and find relevant places to update that way.

Thoughts?


Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: future of serial and identity columns
Next
From: Denis Laxalde
Date:
Subject: [PATCH] Reset single-row processing mode at end of pipeline commands queue