RE: Determine parallel-safety of partition relations for Inserts - Mailing list pgsql-hackers

From Hou, Zhijie
Subject RE: Determine parallel-safety of partition relations for Inserts
Date
Msg-id 2c70b3dd4ce947b98b37d47e19434685@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
In response to Re: Determine parallel-safety of partition relations for Inserts  (Greg Nancarrow <gregn4422@gmail.com>)
Responses RE: Determine parallel-safety of partition relations for Inserts
List pgsql-hackers
> > IMO, It seems more readable to extract all the check that we can do
> > before the safety-check and put them in the new function.
> >
> > Please consider it for further review.
> >
> 
> I've updated your v2 patches and altered some comments and documentation
> changes (but made no code changes) - please compare against your v2 patches,
> and see whether you agree with the changes to the wording.
> In the documentation, you will also notice that in your V2 patch, it says
> that the "parallel_dml_enabled" table option defaults to false.
> As it actually defaults to true, I changed that in the documentation too.

Hi greg,

Thanks a lot for the document update, LGTM.

Attaching v4 patches with the changes:
 * fix some typos in the code.
 * store partitioned reloption in a separate struct PartitionedOptions, 
   making it more standard and easier to expand in the future.

Please consider it for further review.

Best regards,
Houzj




Attachment

pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: a verbose option for autovacuum
Next
From: "Euler Taveira"
Date:
Subject: Re: [PATCH] Doc: improve documentation of oid columns that can be zero. (correct version)