Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Date
Msg-id 2c12c34b-8a71-888f-a6e2-757a03ba56f3@postgresfriends.org
Whole thread Raw
In response to Allow WindowFuncs prosupport function to use more optimal WindowClause options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
List pgsql-hackers
On 10/12/22 04:40, David Rowley wrote:
> I've not really done any analysis into which other window functions
> can use this optimisation. The attached only adds support to
> row_number()'s support function and only converts exactly "RANGE
> UNBOUNDED PRECEDING AND CURRENT ROW" into "ROW UNBOUNDED PRECEDING AND
> CURRENT ROW".  That might need to be relaxed a little, but I've done
> no analysis to find that out. 

Per spec, the ROW_NUMBER() window function is not even allowed to have a 
frame specified.

     b) The window framing clause of WDX shall not be present.

Also, the specification for ROW_NUMBER() is:

     f) ROW_NUMBER() OVER WNS is equivalent to the <window function>:

         COUNT (*) OVER (WNS1 ROWS UNBOUNDED PRECEDING)


So I don't think we need to test for anything at all and can 
indiscriminately add or replace the frame with ROWS UNBOUNDED PRECEDING.
-- 
Vik Fearing




pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: test_decoding assertion failure for the loss of top-sub transaction relationship
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher