Postgres Pro
Downloads
Home   >   mailing lists

Re: Refactoring postgres_fdw code to rollback remote transaction - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Refactoring postgres_fdw code to rollback remote transaction
Date
Msg-id 2a767435-9a92-a6fb-4b59-a81434dda1ab@oss.nttdata.com
Whole thread Raw
In response to Re: Refactoring postgres_fdw code to rollback remote transaction  (Zhihong Yu <zyu@yugabyte.com>)
Responses Re: Refactoring postgres_fdw code to rollback remote transaction  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 

On 2021/09/17 11:40, Zhihong Yu wrote:
> +           goto fail;          /* Trouble clearing prepared statements */
> 
> The label fail can be removed. Under the above condition,  entry->changing_xact_state is still true. You can
directly return.

Thanks for the review! Yes, you're right. Attached the updated version of the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: Refactoring postgres_fdw code to rollback remote transaction
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Split xlog.c